----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122970/#review77880 -----------------------------------------------------------
Ship it! Yep (looks like you posted a followup commit rather than merging the two, and the commit log on reviewboard is outdated, it still talks about V3). But if you make sure to review and clean up the commit, you can commit. - David Faure On March 18, 2015, 1:07 p.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122970/ > ----------------------------------------------------------- > > (Updated March 18, 2015, 1:07 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kjobwidgets > > > Description > ------- > > This fixes source compatibility from https://git.reviewboard.kde.org/r/122926/ > > It adds a new org.kde.JobViewV3.xml file. The DBus interface name is still > JobViewV2 to keep compatibility with apps still using org.kde.JobViewV2.xml. > It also removes generating code from old org.kde.JobView.xml as it is not > used anywhere. > > > Diffs > ----- > > src/CMakeLists.txt c539bdc > src/kuiserverjobtracker.cpp 7f13a4d > src/kuiserverjobtracker_p.h daf3902 > src/org.kde.JobView.xml f64d232 > src/org.kde.JobViewV2.xml 245a5f0 > > Diff: https://git.reviewboard.kde.org/r/122970/diff/ > > > Testing > ------- > > plasma-workspace stable now builds fine > changing V2 -> V3 in CMakeFiles.txt in master branch enable the new setError > method. > > > Thanks, > > David Rosca > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
