----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122981/ -----------------------------------------------------------
(Updated April 3, 2015, 5:50 p.m.) Review request for KDE Frameworks, Martin Gräßlin and Thomas Lübking. Changes ------- - Introduce 'const' at the right places to make a call of d->updateGlobalShortcut() in shortcut() possible. - But the call is commented out because more unit test fail Repository: kglobalaccel Description ------- In some cases you need to call loadShortcutFromGlobalSettings() in order not to get a an empty list when calling shortcut() (which is const). See discussion in https://git.reviewboard.kde.org/r/122249/ ("libksysguard: add Kill Window to End Process button and show correct keyboard shortcut"). Diffs (updated) ----- autotests/kglobalshortcuttest.h b1122a8f5ca2f3f7afbe78f8edba87325426c1a6 autotests/kglobalshortcuttest.cpp 3b661bbb612807a3bbbe34835d4ae712c2ec74da src/kglobalaccel.h 3fe20ca8e4ec6ceb0bb9e54235aef7f1aeeb8c16 src/kglobalaccel.cpp 1b6b3f5cb6d42401d684e6a491d12a6e57248fd1 src/kglobalaccel_p.h eca7c52378ad60d0d5806561214b9788dd46a11e Diff: https://git.reviewboard.kde.org/r/122981/diff/ Testing ------- Thanks, Gregor Mi
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
