> On April 13, 2015, 7:13 a.m., David Faure wrote: > > examples/CMakeLists.txt, line 5 > > <https://git.reviewboard.kde.org/r/123349/diff/1/?file=361005#file361005line5> > > > > well i thought maybe someone wants to see how to use this in their > > app... but ok IIRC it also shows that on api.kde.org > > Jan Grulich wrote: > +1 for removing, it should be same for all frameworks, so there is no > need to mention how to find the library.
In quick search I could not find those information on api.kde.org. You have got a point that keeping those lines in CMakeLists.txt makes things easier for beginners. Let's keep them commented. This patch has +1 after changing examples/createconnection/CMakeLists.txt. - Lamarque ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123349/#review78882 ----------------------------------------------------------- On April 12, 2015, 7:57 p.m., David Faure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123349/ > ----------------------------------------------------------- > > (Updated April 12, 2015, 7:57 p.m.) > > > Review request for KDE Frameworks and Jan Grulich. > > > Repository: networkmanager-qt > > > Description > ------- > > This is built as part of the framework, so it should not do > find_package on itself, it won't work the first time. > > I assume this was there in order to all build separately, so I left > it commented out, but it's wrong to have that in. > > Maybe with the last two commits, the examples can be built by default, > like in the other frameworks, so that we ensure that they always do build? > > > Diffs > ----- > > examples/CMakeLists.txt c2484b346b70596ddeb87778c7dd3881851441fb > > Diff: https://git.reviewboard.kde.org/r/123349/diff/ > > > Testing > ------- > > rebuilt the examples from scratch, worked > > > Thanks, > > David Faure > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
