----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123401/#review79136 -----------------------------------------------------------
Ship it! The patch looks good to me. Network firewall here blocks 'git pull' (among serveral other services) so I could not test it myself. Plasma NM can be fixed later. - Lamarque Souza On April 17, 2015, 3:53 p.m., Hrvoje Senjan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123401/ > ----------------------------------------------------------- > > (Updated April 17, 2015, 3:53 p.m.) > > > Review request for KDE Frameworks, David Faure and Jan Grulich. > > > Repository: networkmanager-qt > > > Description > ------- > > The headers include <networkmanagerqt_export.h>, which is now in lowercase > directory, and is not in public INTERFACE includes. We need to change all the > includes, and place where the export is generated. > > > Diffs > ----- > > src/CMakeLists.txt 0dc3f2e > src/accesspoint.h 99895ef > src/activeconnection.h 6edd0ae > src/adsldevice.h d7c92ba > src/bluetoothdevice.h 4baf4a3 > src/bonddevice.h 82eafa2 > src/bridgedevice.h 68b3e00 > src/connection.h a20d1f7 > src/device.h bca098b > src/dhcp4config.h 35082ba > src/dhcp6config.h 91ca914 > src/genericdevice.h d95fab0 > src/generictypes.h cd45430 > src/gredevice.h eeb682c > src/infinibanddevice.h c9597cb > src/ipaddress.h ebc3e5f > src/ipconfig.h 5eb0227 > src/iproute.h 13afe15 > src/macvlandevice.h ab02831 > src/manager.h e79b933 > src/modemdevice.h e40d457 > src/olpcmeshdevice.h 9af2342 > src/secretagent.h 02e4c9a > src/settings.h f5fe486 > src/settings/adslsetting.h 89ab5b5 > src/settings/bluetoothsetting.h 9a32851 > src/settings/bondsetting.h f3ae1ec > src/settings/bridgeportsetting.h 7a8f74a > src/settings/bridgesetting.h 4628cf5 > src/settings/cdmasetting.h ecd30da > src/settings/connectionsettings.h 252f8e9 > src/settings/genericsetting.h 610568a > src/settings/gsmsetting.h 1a152b2 > src/settings/infinibandsetting.h 713e01e > src/settings/ipv4setting.h bdfcc58 > src/settings/ipv6setting.h 7e7ca9e > src/settings/olpcmeshsetting.h 217682d > src/settings/pppoesetting.h a3c5d79 > src/settings/pppsetting.h 4755288 > src/settings/security8021xsetting.h 486f1bc > src/settings/serialsetting.h fa0bf57 > src/settings/setting.h 86c6e83 > src/settings/teamsetting.h ba58a5d > src/settings/template.h 4f9f680 > src/settings/vlansetting.h 8432eab > src/settings/vpnsetting.h 67aea4e > src/settings/wimaxsetting.h 9fd887a > src/settings/wiredsetting.h fec6860 > src/settings/wirelesssecuritysetting.h 5c9a1da > src/settings/wirelesssetting.h 12eed72 > src/teamdevice.h e42bc81 > src/tundevice.h dd66977 > src/utils.h d091c5e > src/vethdevice.h c9322d0 > src/vlandevice.h bfe2948 > src/vpnconnection.h acd0d2e > src/vpnplugin.h 3a4f181 > src/wimaxdevice.h fb202fa > src/wimaxnsp.h c9bd856 > src/wireddevice.h 193710c > src/wirelessdevice.h 6137036 > src/wirelessnetwork.h 1d5cb7b > > Diff: https://git.reviewboard.kde.org/r/123401/diff/ > > > Testing > ------- > > Plasma-nm no longer fails due to original problem, but incorect usage of > nm-qt includes: > > vpnuiplugin.h:31:43: fatal error: NetworkManagerQt/generictypes.h: No such > file or directory > > > Thanks, > > Hrvoje Senjan > >
_______________________________________________ Kde-frameworks-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
