----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123436/#review79252 -----------------------------------------------------------
autotests/accessmanagertest.cpp (line 39) <https://git.reviewboard.kde.org/r/123436/#comment54143> do we need qputenv("KIOSLAVE_ENABLE_TESTMODE", "1") in case the launched KIOs tries to read/write anything. autotests/accessmanagertest.cpp (line 74) <https://git.reviewboard.kde.org/r/123436/#comment54142> then this should say KIO::AccessManager, not the other one. - David Edmundson On April 20, 2015, 1:12 a.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123436/ > ----------------------------------------------------------- > > (Updated April 20, 2015, 1:12 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kio > > > Description > ------- > > I was having some weird behavior I wanted to test, having a test was a > minimum. > > > Diffs > ----- > > autotests/CMakeLists.txt 0a9fcea > autotests/accessmanagertest.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/123436/diff/ > > > Testing > ------- > > The test passes as is. > > Served me to fix: > https://git.reviewboard.kde.org/r/123325/ > https://codereview.qt-project.org/#/c/110745/ > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
