> On April 22, 2015, 9 a.m., Emmanuel Pescosta wrote: > > src/widgets/accessmanager.cpp, line 255 > > <https://git.reviewboard.kde.org/r/123443/diff/1/?file=362233#file362233line255> > > > > IMO you should always verify if the data is readable, because not all > > lib users are trustworthy (assert isn't meant for input validation of > > untrustworthy callers - public api) > > Aleix Pol Gonzalez wrote: > I can do it, but QNetworkAccessManager doesn't do that, and I'd say it's > better to be as similar to QNAM as possible.
Ah ok sry for the noice, didn't know that. Just assumed that they validate it because they mention "data must be opened for reading" in their API docs. - Emmanuel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123443/#review79325 ----------------------------------------------------------- On April 22, 2015, 1:46 a.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123443/ > ----------------------------------------------------------- > > (Updated April 22, 2015, 1:46 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kio > > > Description > ------- > > Also adopts it when using KIO::AccessManager::put. Otherwise it was doing a > ::readAll and then passed the QByteArray around, which isn't very elegant. > > > Diffs > ----- > > autotests/accessmanagertest.cpp 5e4988f > autotests/jobtest.h ef0ec57 > autotests/jobtest.cpp b11e9f9 > src/core/storedtransferjob.h d3e1106 > src/core/storedtransferjob.cpp 7f81d00 > src/widgets/accessmanager.cpp 239281e > > Diff: https://git.reviewboard.kde.org/r/123443/diff/ > > > Testing > ------- > > New test for the new method. > Tests still pass. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
