----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123479/#review79400 -----------------------------------------------------------
LGTM, but I think having/modifying a unit test for this change would be useful. - Matthew Dawson On April 23, 2015, 12:50 p.m., Milian Wolff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123479/ > ----------------------------------------------------------- > > (Updated April 23, 2015, 12:50 p.m.) > > > Review request for KDE Frameworks, David Faure, Marc Mutz, and Volker Krause. > > > Repository: kcoreaddons > > > Description > ------- > > The len in inotify_event includes nulls of the name. To prevent > them from being included in the QString/QByteArray we must filter > them manually with a recent Qt 5 dev build now. See also: > > https://codereview.qt-project.org/#/c/106473/ > > REVIEW: 123479 > > > Diffs > ----- > > src/lib/io/kdirwatch.cpp a75fae012c59021996b46845db2e97abb5526930 > > Diff: https://git.reviewboard.kde.org/r/123479/diff/ > > > Testing > ------- > > I used the test and looked at the output and also ran it against a patched > qtbase with this: > > https://paste.kde.org/pmoue241d > > > Thanks, > > Milian Wolff > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
