----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123589/#review79779 -----------------------------------------------------------
Ship it! Ooops! Good find, thanks. - David Faure On May 2, 2015, 8:38 a.m., Boris Egorov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123589/ > ----------------------------------------------------------- > > (Updated May 2, 2015, 8:38 a.m.) > > > Review request for KDE Frameworks and David Faure. > > > Bugs: 342732 > https://bugs.kde.org/show_bug.cgi?id=342732 > > > Repository: kio > > > Description > ------- > > There was a porting issue with this code: > QStandardPaths::writableLocation do not creates a directory [1], so we > need QDir::mkpath. Commit ff412e0bd3ba54 tried to fix it, but it gone > too far: we need to create directory only up to "/krun/", strings after > that is filename. So we were creating directory instead of file, > confusing some apps. For example, kate [2]. > > 1: http://doc.qt.io/qt-5/qstandardpaths.html#writableLocation > 2: https://bugs.kde.org/show_bug.cgi?id=343329 > > > Diffs > ----- > > src/kioexec/main.cpp 8fb7ef3 > > Diff: https://git.reviewboard.kde.org/r/123589/diff/ > > > Testing > ------- > > New behavior was tested by removing CacheLocation, and it successfully > creates needed path. > > > Thanks, > > Boris Egorov > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel