----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123551/#review79808 -----------------------------------------------------------
Ship it! This sounds like something that should go into KF 5.10. If this is temporary code then doing it "only if new-style plugins haven't been found" doesn't really matter much IMHO. - David Faure On April 28, 2015, 11:16 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123551/ > ----------------------------------------------------------- > > (Updated April 28, 2015, 11:16 p.m.) > > > Review request for KDE Frameworks, KDEPIM and Hrvoje Senjan. > > > Repository: kpeople > > > Description > ------- > > Also support the old backend plugin system in KPeople until dependencies can > adopt the new format. > > > Diffs > ----- > > CMakeLists.txt 6452c2d > metainfo.yaml 7259adb > src/CMakeLists.txt eba092c > src/personpluginmanager.cpp 365280e > src/widgets/CMakeLists.txt bfe1188 > src/widgets/actions.cpp 2f1d60d > src/widgets/persondetailsview.cpp 7c18c74 > > Diff: https://git.reviewboard.kde.org/r/123551/diff/ > > > Testing > ------- > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
