> On mai. 3, 2015, 12:34 p.m., Albert Astals Cid wrote: > > I'm confused, the title say "Remove KAboutData" and then goes and changes > > i18n while breaking it? > > > > I mean i18n handling is relatively easy, and we have pretty good > > documentation at > > https://techbase.kde.org/Development/Tutorials/Localization/i18n_Build_Systems > > on what to do, so i'm kind of sad of "this is not my issue, i'll just > > change stuff enough so that it 'works' for me and for someone else to fix > > it propertly" mindset. > > > > So let me ask you, what are you missing from the above link that makes it > > hard for you to fix the i18n handling? > > Martin Klapetek wrote: > No, it's a "we're a team" mindset. And maybe it's also a "let's help > fulfil one of the points why frameworks were made into frameworks and help > out other projects wanting to use it because we know our own stuff better" > mindset. I kind of don't really expect them to know every single detail of > how KI18n works or what techbase is. > > Nevertheless and more to the point, "add the ecm loading of the existing > kglobalaccel5_qt qm to the daemon" is something that is not in that wiki at > all.
ecm_create_qm_loader(kglobalaccel_QM_LOADER kglobalaccel5_qt) is what src/CMakeLists.txt has. Also the Messages.sh of the runtime needs fixing to use $EXTRACT_TR_STRINGS as src/Messages.sh is - Albert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122680/#review79794 ----------------------------------------------------------- On mai. 1, 2015, 7:18 p.m., Jerome Leclanche wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122680/ > ----------------------------------------------------------- > > (Updated mai. 1, 2015, 7:18 p.m.) > > > Review request for KDE Frameworks, Localization and Translation (l10n), > Albert Astals Cid, Martin Gräßlin, and Martin Klapetek. > > > Repository: kglobalaccel > > > Description > ------- > > Remove the runtime's KAboutData > > The about data was unexposed, but created a dependency on KCoreAddons (for > KAboutData) and in turn on KI18n for the translations of the aboutData. > > This removes both dependencies as well as the string extraction scripts. > > -- > > Author notes: This is a RFC. We don't use kglobalaccel in LXQt but we would > like to, however it currently has too many dependencies. See > https://github.com/lxde/lxqt/issues/507 for related discussion. > I'm unsure myself if the about data is actually exposed somewhere I completely > missed, but it doesn't look that way. > > > Diffs > ----- > > CMakeLists.txt 68ad795 > src/runtime/CMakeLists.txt e639fa5 > src/runtime/globalshortcutsregistry.cpp 3e4d720 > src/runtime/kglobalacceld.cpp 4e7cb9d > src/runtime/main.cpp fdf4d62 > > Diff: https://git.reviewboard.kde.org/r/122680/diff/ > > > Testing > ------- > > Compiles and runs. No further testing done. > > > Thanks, > > Jerome Leclanche > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
