----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123679/#review80082 -----------------------------------------------------------
Ship it! Ship It! - Milian Wolff On May 8, 2015, 10:42 a.m., Jan Kundrát wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123679/ > ----------------------------------------------------------- > > (Updated May 8, 2015, 10:42 a.m.) > > > Review request for KDE Frameworks and Stephen Kelly. > > > Repository: kitemmodels > > > Description > ------- > > Turns out that there's apparently no overload accepting a QPointer as > the first argument. > > This is on Gentoo with qtbase e374ffc29c67493a51527117b55a53dfa5dd4267 > and GCC 4.8.3. > > Also make sure to tie the lifetime of the connection with `this` because > the lambda accesses our D-pointer, which means that it has to be > disconnected on destruction of `this`. Thanks to Milian Wolff for > catching this. > > REVIEW: 123679 > > > Diffs > ----- > > src/kselectionproxymodel.cpp 0755fb1ca527dde8287ba2607d915a4e18c20134 > > Diff: https://git.reviewboard.kde.org/r/123679/diff/ > > > Testing > ------- > > > Thanks, > > Jan Kundrát > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
