> On May 15, 2015, 9:49 p.m., David Faure wrote: > > About your commit log: we won't have a different coding style for karchive, > > all frameworks should follow > > https://techbase.kde.org/Policies/Kdelibs_Coding_Style > > and > > https://techbase.kde.org/Policies/Library_Code_Policy > > > > About the diff: so this is the result of uncrustify, not astyle? Can you > > put the uncrustify script in kde-dev-scripts too? > > Guy Maurel wrote: > I found a problem with the two references you give: > The first says: > For pointers or references, use a single space before '*' or '&', but > not after > The second: > QString myMethod( const QString& foo, > which one is to follow? > > The diff I provided is a product of astyle with some more scripts (not > provided by astyle). > uncrustify provides much more diversity (500 options). Is more complicate. > I am working on uncrustify to provide an uncrustiy script to follow the > kdelibs.
The first one is to follow; the second link (Library_Code_Policy) says on top "For kdelibs, it is recommended to follow the Kdelibs Coding Style." That page however should be edited to follow the kdelibs style too (it's currently moreless random). - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123803/#review80430 ----------------------------------------------------------- On May 17, 2015, 6:03 p.m., Guy Maurel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123803/ > ----------------------------------------------------------- > > (Updated May 17, 2015, 6:03 p.m.) > > > Review request for KDE Frameworks, Mario Bensi and David Faure. > > > Repository: karchive > > > Description > ------- > > We use for karchive the same rules as for kdepim: > http://techbase.kde.org/Policies/Kdepim_Coding_Style > > If wished, we could have extra policy for karchive. > (Let me know) > > > Diffs > ----- > > src/k7zip.cpp edd1090234e34d669f42815c9d2c653291c0fd2a > src/kar.cpp fb31185 > src/karchive.cpp 1b3371b1479581eb1d83f8f245cf3b85677517d0 > src/kbzip2filter.cpp 52acb76 > src/kcompressiondevice.cpp 05d6859 > src/kfilterdev.cpp dd9e6a3 > src/kgzipfilter.cpp 160cff57d851820f92c99da6a2fe034ebdd4c8b5 > src/klimitediodevice.cpp 66b9b3d > src/knonefilter.cpp 055fab9 > src/krcc.cpp cb8b2cca8262ed0986cc52d01c7b44d5662d1dd5 > src/ktar.cpp 1386382939bb0f0e3a0b9b2b841b909a03ec6e85 > src/kxzfilter.cpp 0e7ae09ccae30e179d63400de921c259e832cb2a > src/kzip.cpp 4bbbcf5464a9e5aae305798201fda641e5b744f2 > > Diff: https://git.reviewboard.kde.org/r/123803/diff/ > > > Testing > ------- > > > Thanks, > > Guy Maurel > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
