> On May 29, 2015, 2:45 p.m., David Faure wrote: > > I'm not sure this is a good idea, usability wise. Miss an icon by one > > pixel, and the effect is to go up, making the whole set of icons disappear? > > Ashish Bansal wrote: > Well about usability there's already discussion going on dolphin RR > 123658. Single click is the way to select a directory(atleast by default). > So, even if someone wants to select an directory and misses it, it won't go > up. Go up behaviour is only when one would use double click :) > > David Faure wrote: > Well, it would still be a huge problem for people using double-click mode > (e.g. my wife). > > David Faure wrote: > Maybe this feature should only be activated in single-click-mode. > > Ashish Bansal wrote: > That sounds good! > > Arjun AK wrote: > >Maybe this feature should only be activated in single-click-mode. > > Are you sure thats a good idea? If i disable/enable single click mode, it > should only change that behaviour and not add/remove a completely unrelated > feature.
I agree with Arjun; plus if you change the behavior in one patch, the other one must stay consistent (123658). - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123929/#review80946 ----------------------------------------------------------- On May 30, 2015, 2:42 p.m., Ashish Bansal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123929/ > ----------------------------------------------------------- > > (Updated May 30, 2015, 2:42 p.m.) > > > Review request for Dolphin, KDE Frameworks, KDE Usability, David Faure, and > Martin Klapetek. > > > Repository: kio > > > Description > ------- > > If mouse double click is done on the empty area, then go to parent directory. > > RR 123658 (dolphin) > > > Diffs > ----- > > src/filewidgets/kdiroperator.h 6d601f3 > src/filewidgets/kdiroperator.cpp 4a7ef02 > > Diff: https://git.reviewboard.kde.org/r/123929/diff/ > > > Testing > ------- > > Works fine! > > > Thanks, > > Ashish Bansal > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
