----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124129/#review81597 -----------------------------------------------------------
+1 from me, just one change below. It's more semantically correct, and avoids a potential bug kicking around in KConfig. src/core/kauthorized.cpp (line 181) <https://git.reviewboard.kde.org/r/124129/#comment55934> This should open with the NoGlobals flag, to avoid reading in the globals file twice. This should be changed in all instances. - Matthew Dawson On June 19, 2015, 3:20 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124129/ > ----------------------------------------------------------- > > (Updated June 19, 2015, 3:20 p.m.) > > > Review request for KDE Frameworks and Matthew Dawson. > > > Repository: kconfig > > > Description > ------- > > This was broken in porting, it used to be KGlobal::config() which opens > the kdeglobals file, KSharedConfig::openConfig() opens a config file for > that application, rather than a global file. > > > Diffs > ----- > > src/core/kauthorized.cpp 4280524dd292a464ad577b04ba1a03a52c7868f5 > > Diff: https://git.reviewboard.kde.org/r/124129/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
