----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124138/#review81608 -----------------------------------------------------------
+1 on moving it from me. I don't think anyone will mind as it's a development tool. However, please don't rename the executable. It's nice that the executable already is namespaced for KF6 (may that be long in the future), and makes it easy to find if someone wasn't using CMake. Also, please don't forget a Changelog: entry on the commit message. Otherwise looks fine to me, but I'd prefer someone to check off the CMake part. - Matthew Dawson On June 20, 2015, 8:30 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124138/ > ----------------------------------------------------------- > > (Updated June 20, 2015, 8:30 p.m.) > > > Review request for KDE Frameworks, Matthew Dawson and Harald Sitter. > > > Repository: kconfig > > > Description > ------- > > This will make it end up in a platform-dependent prefix (i.e. /usr/lib64, > /usr/lib/arm-linux-gnueabihf, etc) rather than /usr/bin, making it possible > to have different kconfig_compiler versions installed, useful for > cross-compilation. > > > Diffs > ----- > > src/kconfig_compiler/CMakeLists.txt 0937f57 > > Diff: https://git.reviewboard.kde.org/r/124138/diff/ > > > Testing > ------- > > Changed and recompiled everything, nothing seems to break as cmake adapts the > *Target.cmake files to the new path. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
