----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124239/#review82028 -----------------------------------------------------------
Ship it! Good catch ! Ship it ! Thanks for unittest too - Laurent Montel On juil. 3, 2015, 9:13 matin, Milian Wolff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124239/ > ----------------------------------------------------------- > > (Updated juil. 3, 2015, 9:13 matin) > > > Review request for KDE Frameworks, David Faure and Laurent Montel. > > > Repository: kdelibs4support > > > Description > ------- > > We want to check the validity of the contained data, not of the > Ptr object itself. Fixes various crashes in KMail & friends. > > > Diffs > ----- > > autotests/kmimetypetest.h 0f762d38f14b6f919322d05bcdb8a74f1fc1a7e2 > autotests/kmimetypetest.cpp c7db1cb64ec5470a5590b783d46fc97d1d2e89d8 > src/kdecore/kmimetype.h 93bbddc8d9be8f8b6bdb3003dfbe9558d24aff9b > > Diff: https://git.reviewboard.kde.org/r/124239/diff/ > > > Testing > ------- > > > Thanks, > > Milian Wolff > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel