-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124315/
-----------------------------------------------------------
Review request for Kate and KDE Frameworks.
Bugs: 350025
https://bugs.kde.org/show_bug.cgi?id=350025
Repository: ktexteditor
Description
-------
Change default keyboard shortcut for "go to previous editing line" as it is in
conflict with default shortcut for "next tab" action. The katepart is likely to
be used in an application that has tabs, so having a conflict with one of the
default shortcuts for changing tabs is not so good. This turns up in Krusader,
bug 350025. Currently Kate uses the wrong default shortcuts for next/prev tab,
so currently there is no conflict there. I will also make a review request for
Kate to use correct shortcuts and if accepted the same conflict will appear
there.
The choice of using ctrl+E, ctrl+shift+E, was just motivated by "e as in edit"
and that it was available in katepart and kate. There is a standard shortcut
called "text completion" which has ctrl+E as default. This is not used by
katepart and seems unlikely to cause conflict.
Diffs
-----
src/view/kateview.cpp 4e8054f
Diff: https://git.reviewboard.kde.org/r/124315/diff/
Testing
-------
Tested with Kate and Krusader, compiled from master. Only small issue is a new
conflict in Krusader (ctrl+shift+E, used for switching to Editor... but then if
you are using this katepart you already are in the editor.. so no biggie).
Thanks,
Simon Persson
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
