----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124331/#review82521 -----------------------------------------------------------
src/kextracolumnsproxymodel.h (line 39) <https://git.reviewboard.kde.org/r/124331/#comment56929> Are there any of these "not supported" things we might want to support in the future? Can we implement e.g. adding/removing columns at runtime and still keep the abi/api ? I guess for removing columns, one could just add a QSFPM on top and filter out the column. - Sune Vuorela On July 14, 2015, 10:42 a.m., David Faure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124331/ > ----------------------------------------------------------- > > (Updated July 14, 2015, 10:42 a.m.) > > > Review request for KDE Frameworks, Jesper Pedersen and Stephen Kelly. > > > Repository: kitemmodels > > > Description > ------- > > REVIEW: 124331 > > > Diffs > ----- > > autotests/CMakeLists.txt f98e87d49b965998f31c5ede1fefb03b159a150f > autotests/kextracolumnsproxymodeltest.cpp PRE-CREATION > autotests/test_model_helpers.h a44db8a9cb985f69b52be96f0ffe389ebd903d6f > src/CMakeLists.txt 82d776f1fcc2f7b15e74f0ed47702ed570ce9892 > src/kextracolumnsproxymodel.h PRE-CREATION > src/kextracolumnsproxymodel.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/124331/diff/ > > > Testing > ------- > > Wrote autotests (as extensive as possible); used this in one real project, > AFAIK Jesper (blackie) did as well. > > > Thanks, > > David Faure > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
