----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124371/#review82568 -----------------------------------------------------------
Ship it! Ship It! - Bhushan Shah On July 16, 2015, 5:08 p.m., Daniel Vrátil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124371/ > ----------------------------------------------------------- > > (Updated July 16, 2015, 5:08 p.m.) > > > Review request for KDE Frameworks and Marco Martin. > > > Repository: plasma-framework > > > Description > ------- > > The `LookAndFeel` entry does not exist in `kdeglobals` (it's called > `LookAndFeelPackage`), so when the configured LnF package is removed or > renamed, the code will go to endless loop because it never clears the > configuration ine `kdeglobals` correctly. > > We discovered this in Fedora, because we ship our own ugly LnF package, and > we renamed it at some point, which caused KDED to go nuts. > > > Diffs > ----- > > src/platformstatus/platformstatus.cpp e03c16d > > Diff: https://git.reviewboard.kde.org/r/124371/diff/ > > > Testing > ------- > > > Thanks, > > Daniel Vrátil > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel