----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124878/#review84391 -----------------------------------------------------------
Ship it! Please verify the unittests still pass, too. - David Faure On Aug. 22, 2015, 2:17 p.m., Volker Krause wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124878/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2015, 2:17 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kemoticons > > > Description > ------- > > This already contains a cache for the theme, and it is expensive to create > itself. Cuts down the cost in half here. > > Still not perfect though, the currentThemeName() call in theme() parses > kdeglobals every time. And this is called per line for KMail's message > rendering, resulting in more than 15% of the instructions spend in KConfig > parsing code. > > > Diffs > ----- > > src/integrationplugin/ktexttohtml.cpp > 604c18eed06ed76b13aa644fa762a1de6d2f3961 > > Diff: https://git.reviewboard.kde.org/r/124878/diff/ > > > Testing > ------- > > Callgrind + KMail. > > > Thanks, > > Volker Krause > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
