----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124941/#review84428 -----------------------------------------------------------
src/knotificationmanager.cpp (line 3) <https://git.reviewboard.kde.org/r/124941/#comment58447> It's 2015 now src/knotificationmanager.cpp (line 175) <https://git.reviewboard.kde.org/r/124941/#comment58448> Given you already check whether the entry exists before adding it, a removeOne should be sufficient - Kai Uwe Broulik On Aug. 26, 2015, 9:05 nachm., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124941/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2015, 9:05 nachm.) > > > Review request for KDE Frameworks. > > > Repository: knotifications > > > Description > ------- > > Till now every KNotification::notify() call would reparse the whole cache of > configs. With this patch it watches for KNotifyConfig changes and reparses > only those configs that had actually changed. > > > Diffs > ----- > > src/knotificationmanager.cpp 4c648a9 > src/knotificationmanager_p.h 95e13d1 > src/knotifyconfig.h fae17cb > src/knotifyconfig.cpp 6a46a00 > > Diff: https://git.reviewboard.kde.org/r/124941/diff/ > > > Testing > ------- > > Works as expected. > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
