----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125184/#review85260 -----------------------------------------------------------
Ship it! This is very technically a SIC since one could be doing a slot connection to this using the name and it'd still work since moc doesn't know about the private status but it's marked as internal so you deserve that SIC if you were that evil :D - Albert Astals Cid On set. 12, 2015, 8:28 a.m., David Faure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125184/ > ----------------------------------------------------------- > > (Updated set. 12, 2015, 8:28 a.m.) > > > Review request for KDE Frameworks and Albert Astals Cid. > > > Repository: kservice > > > Description > ------- > > It didn't create any actual trouble, but I was debugging a bug with > very weird symptoms related to that DBus signal so I wanted to make sure > this wasn't the issue (turns out it was kbuildsycoca running one time too > many). > > > Diffs > ----- > > src/sycoca/ksycoca.h 9d8b21e3c0f08375bece923c4029b54617f04b7f > src/sycoca/ksycoca.cpp 36718e3ee951df19494031f17dec29d1f4dd39c5 > > Diff: https://git.reviewboard.kde.org/r/125184/diff/ > > > Testing > ------- > > unittests still pass > > > Thanks, > > David Faure > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
