----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125185/ -----------------------------------------------------------
(Updated Sept. 13, 2015, 6:01 p.m.) Status ------ This change has been marked as submitted. Review request for KDE Frameworks, Albert Astals Cid and Ben Cooksley. Changes ------- Submitted with commit c7d4b69044c12394e1136d095674b0a30d03f9f4 by David Faure to branch master. Repository: kservice Description ------- The list of changed resources is not longer available, so we fake it by passing all 4 resources. No big deal, it just removes a small optimization in some apps, and anyway the "apps" resource was emitted in all cases for the last 8 years anyway (vfolder bug that was never fixed). -> un-deprecate the old databaseChanged signal without the resource list ;) KDirWatch beats QFileSystemWatcher once again, after much fighting with QFSW with one failing unittest (KServiceTest::testThreads), I switched to KDirWatch and it worked immediately... REVIEW: 125185 Diffs ----- src/kbuildsycoca/CMakeLists.txt 8c9fd73a73e4fb40461448a9c324990fc16e2bc1 src/kbuildsycoca/kbuildsycoca_main.cpp 4f39c470e474eaae6de9ade7ae5460edd6b00a82 src/sycoca/ksycoca.h f529e59c18f14f3367695d7a1f5cee74ab36b43d src/sycoca/ksycoca.cpp 93514eebec0a7d3b59445e555adf1146a3a00060 src/sycoca/ksycoca_p.h a7d91e6d89b726d336f99bf43a65c16166c1d48e Diff: https://git.reviewboard.kde.org/r/125185/diff/ Testing ------- unittests still pass Thanks, David Faure
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
