----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125263/#review85503 -----------------------------------------------------------
Ship it! src/services/kplugininfo.cpp (line 335) <https://git.reviewboard.kde.org/r/125263/#comment59106> I would call .reserve() on both lists with services.count() as argument. It's too big, but that's not a problem; they go out of scope at the end block, and this way a single allocation is needed for each list. - David Faure On Sept. 16, 2015, 4:52 p.m., Alex Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125263/ > ----------------------------------------------------------- > > (Updated Sept. 16, 2015, 4:52 p.m.) > > > Review request for KDE Frameworks, David Faure and Sebastian Kügler. > > > Repository: kservice > > > Description > ------- > > Keep MIME types separate when converting KPluginInfo to KPluginMetaData > > > Diffs > ----- > > autotests/kplugininfotest.cpp c3a0f8f7a79fc9b063bbcf0f52a5442ae0545432 > src/services/kplugininfo.cpp 93dcb8fc35930d89e4e60efea755b018d329794f > > Diff: https://git.reviewboard.kde.org/r/125263/diff/ > > > Testing > ------- > > new + old unit tests pass > > > Thanks, > > Alex Richardson > >
_______________________________________________ Kde-frameworks-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
