----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125279/ -----------------------------------------------------------
Review request for KDE Frameworks and Albert Astals Cid. Repository: kservice Description ------- This will prevent sycoca-rebuild ping-pong if two apps with different settings would share the same file (and keep finding that it's wrong for them), and it fixes Albert's bug that "LANG=de kcmshell5 --list" doesn't show German translations for the strings coming from desktop files. Diffs ----- autotests/ksycocatest.cpp 7c2d91e056726540b8a3a5c679d9b2a93f023c50 docs/kbuildsycoca5/man-kbuildsycoca5.8.docbook 3419e42cb29c6699bc17e6dd46bbc523139c59eb src/sycoca/kbuildsycoca.cpp 3685211e9da68f14516ec2b3d9a7e6b4f559b6f3 src/sycoca/ksycoca.h c561dfd1550fd28e73144af6d3b2fa9008b17f59 src/sycoca/ksycoca.cpp c5465a828da615e87220304e3f8b160d471edbc7 Diff: https://git.reviewboard.kde.org/r/125279/diff/ Testing ------- unittests, after adjusting ksycocatest which was checking for the old behavior (same file). Albert: there we are, finally ;) Your bug should be fixed (I don't have translations installed to test it, though). Thanks for all the reviews! Thanks, David Faure
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
