> On Set. 21, 2015, 2:54 p.m., Aleix Pol Gonzalez wrote: > > src/CMakeLists.txt, line 645 > > <https://git.reviewboard.kde.org/r/125332/diff/1/?file=404916#file404916line645> > > > > That doesn't seem to make a lot of sense... > > Patrick von Reth wrote: > This is needed as the cmake module path isn't set yet in the install > step and FindPerlModules.cmake needs to be found.
Yes, it's the same thing that happens in KDocTools: https://quickgit.kde.org/?p=kdoctools.git&a=blob&h=136fbfb9aff25f30f10c7eea7b32c65f5a2e6ad8&hb=9faacaecbe8ecf3d1619f2c8fc97248cf23d5260&f=src%2FCMakeLists.txt#l20 and also the first comments in https://git.reviewboard.kde.org/r/124542/ I guess we need more comments here and in KDocTools to explain the entire process (it takes me more than few seconds every time I have to look at it) - so, if there are volunteers... (hint hint :) > On Set. 21, 2015, 2:54 p.m., Aleix Pol Gonzalez wrote: > > cmake/uriencode.cmake, line 2 > > <https://git.reviewboard.kde.org/r/125332/diff/1/?file=404915#file404915line2> > > > > should be kdelibs4support_encode_uri > > Patrick von Reth wrote: > I'll fix that one. Waiting for this fix then :) - Luigi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125332/#review85715 ----------------------------------------------------------- On Set. 21, 2015, 2:41 p.m., Patrick von Reth wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125332/ > ----------------------------------------------------------- > > (Updated Set. 21, 2015, 2:41 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs4support > > > Description > ------- > > Use the more advanced version of uriencode.cmake from kdoctools which > supports Windows. > > > Diffs > ----- > > cmake/FindPerlModules.cmake PRE-CREATION > cmake/uriencode.cmake fde06d3ccf14212122bbee583b44158a2411fbcf > src/CMakeLists.txt 14cc57413b827286ba1d29ccf31e308b05c52413 > > Diff: https://git.reviewboard.kde.org/r/125332/diff/ > > > Testing > ------- > > Windows > > > Thanks, > > Patrick von Reth > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel