----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125531/#review86612 -----------------------------------------------------------
src/lib/io/kprocess.h (line 309) <https://git.reviewboard.kde.org/r/125531/#comment59618> I would say this line is ot needed, given the @deprecated at the end of the docu (we usually don't start with "Obsolete method", unlike Qt) src/lib/io/kprocess.h (line 321) <https://git.reviewboard.kde.org/r/125531/#comment59616> Are you sure that processId() isn't a drop-in replacement on Windows? Note that this method was returning "a real PID also on Windows", unlike QProcess::pid(). src/lib/io/kprocess.cpp (line 328) <https://git.reviewboard.kde.org/r/125531/#comment59617> That looks exactly like the implementation of QProcess::processId() to me. So I would say, QProcess::processId() *is* a drop-in replacement for KProcess::pid(). - David Faure On Oct. 5, 2015, 3:31 p.m., Kurt Hindenburg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125531/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2015, 3:31 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kcoreaddons > > > Description > ------- > > QProcess::pid() has been depreciated since Qt5.3 - the replacement > QProcess::processId() is not a drop-in replacement on non-UNIX systems. > > I'm not positive this is the correct way of doing this. > > http://doc.qt.io/qt-5/qprocess.html#processId > http://doc.qt.io/qt-5/qprocess-obsolete.html#pid > > > Diffs > ----- > > src/lib/io/kprocess.h d57061c > src/lib/io/kprocess.cpp 1df61c0 > > Diff: https://git.reviewboard.kde.org/r/125531/diff/ > > > Testing > ------- > > tests pass > > > Thanks, > > Kurt Hindenburg > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
