----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125598/#review86939 -----------------------------------------------------------
+1 from me as well. For the prefix, I'd prefer to just use kconfig/ instead. When we get to KF6, having everyone move to kconfig6/ seems unnecessary and error prone for no gain. Is there a reason kxmlgui used 5 in the name? Otherwise, I don't think using kconfig(5)/ will be a problem, as it isn't likely someone will use that name in software named something else. - Matthew Dawson On Oct. 13, 2015, 2:20 a.m., Christoph Cullmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125598/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2015, 2:20 a.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kconfig > > > Description > ------- > > Like KXMLGui, KConfig has now a fallback to config files bundled with the > application in resources. > > Like kxmlgui, its in :/kconfig5. > > This allows e.g. KTextEditor deployment without any installed files beside > the library itself and should easy the shipping of default configs for > non-linux/unix platforms. > > Question is if :/kconfig5 is that nice a prefix, at least it is unique and > matches what we do with kxmlgui5. > > > Diffs > ----- > > autotests/CMakeLists.txt 8213bc4 > autotests/fallbackconfigresources.qrc PRE-CREATION > autotests/fallbackconfigresourcestest.cpp PRE-CREATION > src/core/kconfig.cpp 7f03869 > > Diff: https://git.reviewboard.kde.org/r/125598/diff/ > > > Testing > ------- > > Added an unit test to show that the fallback resource is found and read. > > > Thanks, > > Christoph Cullmann > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
