----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125325/#review87117 -----------------------------------------------------------
Almost there ;) src/kcollapsiblegroupbox.h (line 47) <https://git.reviewboard.kde.org/r/125325/#comment59865> missing spaces around the '=' sign src/kcollapsiblegroupbox.h (line 51) <https://git.reviewboard.kde.org/r/125325/#comment59866> showed -> shown. Wait, who's the native speaker again? :-P src/kcollapsiblegroupbox.h (line 68) <https://git.reviewboard.kde.org/r/125325/#comment59867> I think you need two stars here for doxygen to pick this up. src/kcollapsiblegroupbox.h (line 91) <https://git.reviewboard.kde.org/r/125325/#comment59868> I don't think doxygen will pick up one-line comments with this syntax. Either make it 3 lines, or use the correct one-line syntax (which I think is ///! or ///<, not sure). src/kcollapsiblegroupbox.h (line 99) <https://git.reviewboard.kde.org/r/125325/#comment59869> this method is normally public, don't hide it. same for minimumSizeHint() src/kcollapsiblegroupbox.h (line 115) <https://git.reviewboard.kde.org/r/125325/#comment59870> wrong comment (just remove it, imho) src/kcollapsiblegroupbox.cpp (line 62) <https://git.reviewboard.kde.org/r/125325/#comment59871> matches to match? ;) src/kcollapsiblegroupbox.cpp (line 193) <https://git.reviewboard.kde.org/r/125325/#comment59872> (a switch(event->type()) wouldn't hurt...) - David Faure On Oct. 19, 2015, 10:32 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125325/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2015, 10:32 p.m.) > > > Review request for KDE Frameworks and Christoph Feck. > > > Repository: kwidgetsaddons > > > Description > ------- > > A groupbox featuring a clickable header and arrow indicator that can be > expanded and collapsed to reveal the box content > > Widget features a close and collapse animation and works as expected in > QtDesigner. > > -- > Screenshot explains what I mean better than the description above. > > I've been given at least 3 mockups from the VDG mockup which feature using > this widget, clearly there's a demand for it. > > It's a bit like QToolBox, except no-one uses it because QToolbox has a weird > way of only expanding one at a time, and looks a bit weird so no-one uses it. > > > Diffs > ----- > > src/CMakeLists.txt e03e9bbd6d73811873b0a465f86da269f4295138 > src/kcollapsiblegroupbox.h PRE-CREATION > src/kcollapsiblegroupbox.cpp PRE-CREATION > tests/CMakeLists.txt 180b0ef1f8900247da59112612ee87dd3164c8af > tests/kcollapsiblegroupboxtest.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/125325/diff/ > > > Testing > ------- > > Made little test app (see screenshot) > > Wrote QtDesigner plugin, and played with it there. > > > File Attachments > ---------------- > > kcollapsiblegroupbox.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/f9758e22-0043-4876-b462-364c3b2854dc__kcollapsiblegroupbox.png > > > Thanks, > > David Edmundson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel