----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125711/ -----------------------------------------------------------
(Updated Oct. 20, 2015, 8:33 a.m.) Status ------ This change has been marked as submitted. Review request for KDE Frameworks. Changes ------- Submitted with commit b72fc5e56579035bf987075e16324ef95ef8e3d4 by Alex Merry to branch master. Repository: kparts Description ------- When a part's main widget is destroyed, we should not delete the part immediately - both because deleting an object from inside one of its signals is not safe generally, and because derived classes may well hold QPointers to the widgets, expecting them to be cleared between the widget being destroyed and the part being destroyed. Diffs ----- autotests/parttest.cpp c477face2f0f94f1d66deadedb4bc913eaa21842 src/part.cpp 4a3150e8aa2a6ed2aff68c945135b3536db2059d Diff: https://git.reviewboard.kde.org/r/125711/diff/ Testing ------- Unit tests for KParts pass. Running akregator under valgrind no longer produces a bunch of "invalid reads" from KHTMLPart when switching around between articles. Thanks, Alex Merry
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
