> On Oct. 23, 2015, 5:09 p.m., Aleix Pol Gonzalez wrote: > > Ship It!
Eh sorry I pressed that by fault, I don't know how it got confirmed. My actual review follows. - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125766/#review87311 ----------------------------------------------------------- On Oct. 23, 2015, 4:36 p.m., Antonio Larrosa Jimenez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125766/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2015, 4:36 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kded > > > Description > ------- > > Changed the manual command line parsing to use QCommandLineParser instead of > parsing it manually. Also, now kded5 --version and kded5 --help show the > version information and help on options. > > There's a new human readable text ("Check cache validity") that maybe > should be inside i18n, but since kded doesn't user i18n at all and > I wasn't sure it's desired to do so, I just left it untranslated. > > Also, unset SESSION_MANAGER environment variable instead of setting it empty. > This removes a warning from Qt when parsing the (wrong, empty) > value of SESSION_MANAGER > > > Diffs > ----- > > src/kded.cpp 6929d7d3f24d3556f1b227d5a9bfb5b02b1c295e > > Diff: https://git.reviewboard.kde.org/r/125766/diff/ > > > Testing > ------- > > I tested kded5 runs, and the --check, --version and --help options work as > expected. > Also, now it doesn't show a warning every time it's run. I didn't really > check it's > not doing any session management, but SESSION_MANAGER is only used in one > place in qtbase, > at > https://github.com/qtproject/qtbase/blob/dev/src/plugins/platforms/xcb/qxcbsessionmanager.cpp#L350 > and reading that, I think unsetting the environment variable makes more sense. > > > Thanks, > > Antonio Larrosa Jimenez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel