> On Oct. 26, 2015, 2:56 p.m., Martin Klapetek wrote: > > Looks good to me > > > > Do you have commit access? > > Ilia Kats wrote: > I think so, yes, although I have not used it for quite a while. Should I > try to push and see what happens? > > Martin Klapetek wrote: > Ideally you should wait for someone giving you a ship it. > > Ilia Kats wrote: > Sorry, I thought your comment indicated that. waiting...
I'm not the maintainer of this code and don't know this code that well, so would like to give a chance to the maintainer to approve it. But if nobody else gives you ship it by Friday, you can consider this a one. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125779/#review87425 ----------------------------------------------------------- On Oct. 25, 2015, 9:23 a.m., Ilia Kats wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125779/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2015, 9:23 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kio > > > Description > ------- > > previously, two clicked() events were emitted upon middle click, one with > Qt::MidButton and one with Qt::LeftButton, resulting in e.g. Dolphin both > opening a new tab as well as changing the location of the current tab. This > fixes that > > > Diffs > ----- > > src/filewidgets/kurlnavigatorbutton.cpp e6aafb7 > src/filewidgets/kurlnavigatorbutton_p.h dbb3e7b > src/filewidgets/kurlnavigatormenu.cpp d492c7c > src/filewidgets/kurlnavigatormenu_p.h 70133d1 > > Diff: https://git.reviewboard.kde.org/r/125779/diff/ > > > Testing > ------- > > Opened Dolphin, tried left/right/middle click on the menu -> behaves as > expected. > > > Thanks, > > Ilia Kats > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
