> On Oct. 31, 2015, 8:39 a.m., David Faure wrote: > > This is clearly missing an "else" for other cases like an http proxy, can > > you add it, even without being able to test it? > > > > In any case this is a clear improvement. > > Xuetian Weng wrote: > I'm not aware that http proxy can handle arbitrary tcp connection :| .. > is it supported?
Another thing is that connectToHostEncrypted doesn't have ProxyPolicy argument in current API comparing with connectToHost. Does a new function need to be added? - Xuetian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125885/#review87773 ----------------------------------------------------------- On Oct. 30, 2015, 11:26 p.m., Xuetian Weng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125885/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2015, 11:26 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Bugs: 342402 > https://bugs.kde.org/show_bug.cgi?id=342402 > > > Repository: kio > > > Description > ------- > > Automatically set socks5 proxy in KTcpSocket. > > > Diffs > ----- > > src/core/ktcpsocket.h ffa3f0b > src/core/ktcpsocket.cpp fde35a7 > > Diff: https://git.reviewboard.kde.org/r/125885/diff/ > > > Testing > ------- > > Test with akonadi imap agent, connect through socks5 proxy. > > > Thanks, > > Xuetian Weng > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
