----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124714/#review87955 -----------------------------------------------------------
Sorry I've let this sit for so long - Real Life(TM) got in the way. Rather than adding variables for each of these, I'd rather have some way to add free text to this field. Also, have you checked that an extra line break doesn't get added when the fields are not set? Finally, have you explored ways to make these *not* be required? I don't know QMake's build system very well, but it seems to me that at least some of these might be able to go in the .pri file (and it might be possible to protect client projects from the need to set QT_NO_KEYWORDS). - Alex Merry On Aug. 12, 2015, 1:13 p.m., Lamarque Souza wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124714/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2015, 1:13 p.m.) > > > Review request for KDE Frameworks and Alex Merry. > > > Repository: kapidox > > > Description > ------- > > NetworkManagerQt requires some options to be added to .pro file to compile: > > QT += NetworkManagerQt dbus network > CONFIG += link_pkgconfig > PKGCONFIG += libnm # from NetworkManager package > DEFINES += QT_NO_KEYWORDS # libnm declares a variable named signals > > kapidox already supports the first option (QT), but not the others. This > patch adds support to adding the other three options. > > > Diffs > ----- > > src/kapidox/data/templates/fwinfo.html a20c1d1 > > Diff: https://git.reviewboard.kde.org/r/124714/diff/ > > > Testing > ------- > > I added the lines below to networkmanager-qt/metainfo.html and kapidox > created the correct output: > > qmakepro: > - config: link_pkgconfig > - defines: QT_NO_KEYWORDS > - pkgconfig: libnm > > > Thanks, > > Lamarque Souza > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
