> On Nov. 19, 2015, 5:38 p.m., David Edmundson wrote: > > src/plasma/svg.cpp, line 47 > > <https://git.reviewboard.kde.org/r/126113/diff/1/?file=417438#file417438line47> > > > > An SVG with colours will have a Theme object (via > > SvgPrivate::cacheAndColorsTheme()) > > > > ThemePrivate already has an (effecively shared) event filter on colours > > changing, can we use directly?
good idea - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126113/#review88619 ----------------------------------------------------------- On Nov. 20, 2015, 11:18 a.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126113/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2015, 11:18 a.m.) > > > Review request for KDE Frameworks and Plasma. > > > Bugs: 351923 > http://bugs.kde.org/show_bug.cgi?id=351923 > > > Repository: plasma-framework > > > Description > ------- > > since seems there are so many event filters installed on the QApplication > installed that may give performance issues, try to use separate, singleton > watchers for them to decrease the amount of eventfilters called > > > Diffs > ----- > > src/plasma/svg.cpp bcceaf7 > src/plasma/private/theme_p.h 5b8f71c > src/plasma/private/theme_p.cpp f346343 > src/declarativeimports/core/units.h fa2256e > src/declarativeimports/core/units.cpp 4e2adae > src/plasma/private/svg_p.h 597465e > > Diff: https://git.reviewboard.kde.org/r/126113/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
