----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126087/ -----------------------------------------------------------
(Updated Nov. 20, 2015, 3:03 p.m.) Review request for KDE Frameworks, Chusslove Illich and Marco Martin. Changes ------- Change the API into QVariant so we can have more control on the types, instead of leaving up to QML to do the type conversion. Maybe it would be better to use QJSValue here, so that we didn't need the QJSValue -> QVariant conversion. This would require having the QML dependency though (and a separate object as well, probably). Repository: ki18n Description ------- The only way to use `i18n*()` so far in QML is by depending on all KDeclarative. This patch moves the necessary bits there so it can be adopted by an application or framework just by offering the needed bits within KI18n. This is done by offering an object with methods that map to the `i18n*()` C++ counter-parts. Diffs (updated) ----- autotests/CMakeLists.txt 1cf0f7a autotests/ki18ndeclarativetest.cpp PRE-CREATION autotests/test.qml PRE-CREATION docs/programmers-guide.md 13a5f9d src/CMakeLists.txt 818595e src/klocalizedcontext.h PRE-CREATION src/klocalizedcontext.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/126087/diff/ Testing ------- Ported KDeclarative, everything still seems to work. Thanks, Aleix Pol Gonzalez
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
