----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126140/#review88774 -----------------------------------------------------------
Ship it! Looks good, but should be two different commits of course. Would this have been caught by -DQT_NO_CAST_FROM_ASCII? - David Faure On Nov. 23, 2015, 9:01 p.m., Nick Shaforostoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126140/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2015, 9:01 p.m.) > > > Review request for KDE Frameworks, Juan Palacios, Pino Toscano, and Vishesh > Handa. > > > Repository: kfilemetadata > > > Description > ------- > > also this patch marks 'audio/mp4' mimetype as supported by taglib for reading > .m4a files (AAC or ALAC) > > > Diffs > ----- > > src/extractors/taglibextractor.cpp 3bf33cd > > Diff: https://git.reviewboard.kde.org/r/126140/diff/ > > > Testing > ------- > > tested with Spanish accents (e.g. José, Cátulo) in the tags. > > also i did test this toCWString-based conversion on windows and it worked > fine. should work on osx as well > > > Thanks, > > Nick Shaforostoff > >
_______________________________________________ Kde-frameworks-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
