----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126222/#review89052 -----------------------------------------------------------
That code was added to fix this bug https://bugs.kde.org/show_bug.cgi?id=171343#c6 - Lamarque Souza On Dec. 2, 2015, 4:34 p.m., Xuetian Weng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126222/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2015, 4:34 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kwidgetsaddons > > > Description > ------- > > mousePressed and mouseMoved seems to contains some hack code. I don't know > what these hacks are originally for, but it seems that they are not valid > anymore and causes problem. > > Currently, whenever a mouse move happens, the rating value cycles between 0, > 1, 2. This change drops all hack code. > > > Diffs > ----- > > src/kratingwidget.cpp d0d2903 > > Diff: https://git.reviewboard.kde.org/r/126222/diff/ > > > Testing > ------- > > No flickering anymore when selecting rating. > Tested with following case, all cases are able to select all possible rating > value. > setMaxRating(2) setHalfStepsEnabled(false) > setMaxRating(1) setHalfStepsEnabled(false) > setMaxRating(1) setHalfStepsEnabled(true) > setMaxRating(5) setHalfStepsEnabled(true) > > > Thanks, > > Xuetian Weng > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
