----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126230/#review89085 -----------------------------------------------------------
This looks interesting, but it seems like it would make it really hard to debug why the function isn't there because some dependencies are missing... Maybe a warning is enough? - Aleix Pol Gonzalez On Dec. 3, 2015, 1:26 p.m., Boudewijn Rempt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126230/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2015, 1:26 p.m.) > > > Review request for KDE Frameworks and Aleix Pol Gonzalez. > > > Repository: ki18n > > > Description > ------- > > When building ki18n as a dependency framework for shipping with an > application, the tools to actually create and manage translations are > superfluous. These tools have some big dependencies that are a pain to have > around, especially gettext on Windows. This patch makes the requirement for > Python and Gettext optional. > > This patch checks the BUILD_TESTING variable to see if the autotests should > be built, because when we just need the library to build an application we > shouldn't waste electicity building the tests (and the Qt5::QML dependency). > > > Diffs > ----- > > CMakeLists.txt 59917fa > cmake/KF5I18NMacros.cmake 53ba812 > > Diff: https://git.reviewboard.kde.org/r/126230/diff/ > > > Testing > ------- > > > Thanks, > > Boudewijn Rempt > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
