----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126329/ -----------------------------------------------------------
Review request for KDE Frameworks. Repository: kio Description ------- Strings that are separated into multiple parts don't work on Windows together with QStringLiteral as the first string is interpreted as a wide (16bit) string, and the second one as a narrow (8bit) string. Replacing with QString::fromLatin1 is the easiest solution keeping the code layout the same, joining the strings does work too though. Diffs ----- autotests/dataprotocoltest.cpp 9fe238fdbb0e9682141772d423a64edd5621921b src/core/ksambashare.cpp a3f84ac3971141e687d9ab17e0131a66db34ed5a src/filewidgets/kfileplacesmodel.cpp b409c1b1617f97f3cdbc79a2c76110a5f9449398 src/ioslaves/help/kio_help.cpp cb27a77b22fe378a126d985621985265edb93767 src/widgets/kpropertiesdialog.cpp 0ff506273a10dba238fefc5c552c71434681285e Diff: https://git.reviewboard.kde.org/r/126329/diff/ Testing ------- Windows. Thanks, Patrick Spendrin
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
