> On Dec. 23, 2015, 3:49 p.m., Aleix Pol Gonzalez wrote: > > src/k7zip.cpp, line 2029 > > <https://git.reviewboard.kde.org/r/126429/diff/1/?file=424823#file424823line2029> > > > > I wouldn't get this all in. Is that suggested by > > `-Wclazy-reserve-candidates`? > > Artur Puzio wrote: > Yes this is suggested by `-Wclazy-reserve-candidates`. > > Sergio Martins wrote: > I think this one is not worth it, as it makes the code more complex. > Also note that QVector already has a growth strategy, so it's not > terrible. > > Artur Puzio wrote: > It for sure makes the code run faster and be more memory efficient, but > if you want I can remove this.
Yes, please. Remove it. - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126429/#review89995 ----------------------------------------------------------- On Dec. 23, 2015, 3:49 p.m., Artur Puzio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126429/ > ----------------------------------------------------------- > > (Updated Dec. 23, 2015, 3:49 p.m.) > > > Review request for KDE Frameworks, Aleix Pol Gonzalez and Sergio Martins. > > > Repository: karchive > > > Description > ------- > > Fixed warning: Folder has dtor but not copy-ctor, copy-assignment > [-Wclazy-rule-of-three], by adding Q_DISABLE_COPY(Folder) > Fixed warning: Reserve candidate [-Wclazy-reserve-candidates], by > precalculateing QVector size. > Fixed warning: unused variable [-Wunused-const-variable], by commenting > unused variables > > > Diffs > ----- > > src/k7zip.cpp 7b5e6a3 > > Diff: https://git.reviewboard.kde.org/r/126429/diff/ > > > Testing > ------- > > Automated tests pass. > > > Thanks, > > Artur Puzio > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel