> On Jan. 7, 2016, 4:51 p.m., Aleix Pol Gonzalez wrote: > > src/kpackagetool/kpackagetool.cpp, line 351 > > <https://git.reviewboard.kde.org/r/126662/diff/1/?file=428750#file428750line351> > > > > Why's this change? > > Mihail Ivchenko wrote: > Otherwese clazy warns about detaching temporary. If this change isn't > need I can remove that one.
Ok, makes sense. - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126662/#review90762 ----------------------------------------------------------- On Jan. 7, 2016, 4:42 p.m., Mihail Ivchenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126662/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2016, 4:42 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kpackage > > > Description > ------- > > GCI task: > https://codein.withgoogle.com/dashboard/task-instances/5822614106800128/ > > > Diffs > ----- > > src/kpackagetool/kpackagetool.cpp 61a0043 > src/kpackage/private/packages_p.h 27b8ed9 > src/kpackage/packageloader.cpp 9f7dd48 > > Diff: https://git.reviewboard.kde.org/r/126662/diff/ > > > Testing > ------- > > Tests passed > > > Thanks, > > Mihail Ivchenko > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
