----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126674/#review90833 -----------------------------------------------------------
Ship it! Code looks good, only found some coding style issues thumbnail/CMakeLists.txt (line 224) <https://git.reviewboard.kde.org/r/126674/#comment62068> trailing space thumbnail/kritacreator.h (line 24) <https://git.reviewboard.kde.org/r/126674/#comment62067> unused thumbnail/kritacreator.h (line 37) <https://git.reviewboard.kde.org/r/126674/#comment62066> Q_DECL_OVERRIDE rather than virtual, on both lines thumbnail/kritacreator.cpp (line 52) <https://git.reviewboard.kde.org/r/126674/#comment62063> On two separate lines please (preferrably with curly braces, like the rest of this file, to match the KF5 coding style) thumbnail/kritacreator.cpp (line 84) <https://git.reviewboard.kde.org/r/126674/#comment62065> indentation looks wrong thumbnail/kritacreator.cpp (line 86) <https://git.reviewboard.kde.org/r/126674/#comment62064> join with } on previous line (or just run astyle-kdelibs from kde-dev-scripts) - David Faure On Jan. 8, 2016, 8:38 a.m., Boudewijn Rempt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126674/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2016, 8:38 a.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kio-extras > > > Description > ------- > > KRA and ORA files are mostly the same internally, a zip container with small > PNG thumbnail. I would like to move the thumbnailer from krita to kio-extras > since it no longer depends on any Krita code, and people who haven't got > Krita installed might still want to see krita or openraster thumbnails in > Dolphin. The actual author of the code is Frinring. > > > Diffs > ----- > > thumbnail/CMakeLists.txt 4addb26 > thumbnail/kraorathumbnail.desktop PRE-CREATION > thumbnail/kritacreator.h PRE-CREATION > thumbnail/kritacreator.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/126674/diff/ > > > Testing > ------- > > > Thanks, > > Boudewijn Rempt > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
