> On Jan. 14, 2016, 11:27 a.m., Marco Martin wrote: > > does the svg stuff still workk? > > this script goes well together the others i have (only in plasma-framework > > atm) to remove the hardcoded colors inkscape likes to put even when an > > element is using the stylesheet and the one to replace hardcoded colors > > with classes of the stylesheet. > > > > > > as for compressing: i was actually thinking of uncompressing the svgs in > > plasma-framework :p (mainly because git) > > > > what needs to happen is probably the compression to svgz to be done at > > build time and have all simple svgs in the repository > > Aleix Pol Gonzalez wrote: > What do you mean with "because git"? Because we might have the exact same > problem with svgo then. > > Sebastian Kügler wrote: > I'm doing an educated guess here: Marco wants readable diffs to icons, so > it's easier to spot if the coloring / stylesheets are still correct.
If so, optmized svgs wouldn't work either, because they are squeezed in one line. Maybe it would be better to use different tooling to see the differences on those cases? - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126740/#review91055 ----------------------------------------------------------- On Jan. 14, 2016, 4 a.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126740/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2016, 4 a.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: breeze-icons > > > Description > ------- > > Dirk's review (https://git.reviewboard.kde.org/r/126738/) gave me the idea > that right now we're serving right away the svg's from inkscape and there's > room for improvement, potentially. > > This patch just introduces a script that optimizes the svg's using `svgo`. > > More could be done, like using gzip files, we can look into that if anyone's > interested. In fact, we used to use svgz for the icons, I wonder why that > changed. > > This will change the files in-place rather than as a build step, which is > what I considered first. The process to run svgo on every file was about 30 > minutes to 1h on my system, so I doubt it's really desirable. > > A reduced file size is important because it will greatly reduce disk IO, > which is a bottle-neck we have. > > > Diffs > ----- > > optimize-svg.sh PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/126740/diff/ > > > Testing > ------- > > ``` > kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/ > 32M icons > 32M icons-dark/ > > #run the script > > kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/ > 17M icons > 17M icons-dark/ > ``` > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
