> On Jan. 14, 2016, 2:03 p.m., Sergio Martins wrote: > > Ship It! > > Sergio Martins wrote: > Can you push it in two different commits ? One for the QStringLiteral > change and another for the isEmpty() > > Sergio Martins wrote: > Regarding the qDeleteAll(), the correct way is > qDeleteAll(d->widgetInIndex.keyBegin(), d->widgetInIndex.keyEnd()), but that > only works since Qt 5.6, so ignore this for now > > Andrey Cygankov wrote: > I do not have rights to commit. > I think that it is not necessary to divide the RR into two parts. But I > have divided into two different diff, to make it convenient, here they are: > > https://www.dropbox.com/s/tg1bhg71myv5nqb/kitemviews-clazyfix-tocommit.patch?dl=0 > > https://www.dropbox.com/s/j9chp5rx2cjkeay/kitemviews-isemptyfix-tocommit.patch?dl=0
While at it, can you request the commits right? https://techbase.kde.org/Contribute/Get_a_Contributor_Account - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126737/#review91076 ----------------------------------------------------------- On Jan. 14, 2016, 11:40 p.m., Andrey Cygankov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126737/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2016, 11:40 p.m.) > > > Review request for KDE Frameworks, Aleix Pol Gonzalez and Sergio Martins. > > > Repository: kitemviews > > > Description > ------- > > Fix Clazy warnings, except: > /src/kwidgetitemdelegatepool.cpp:153:5: warning: Calling qDeleteAll with > QHash::keys, call qDeleteAll on the container itself [-Wclazy-qdeleteall] > qDeleteAll(d->widgetInIndex.keys()); > > > Diffs > ----- > > autotests/klistwidgetsearchlinetest.cpp b86d62c > src/kcategorizedview.cpp 185c24c > src/ktreewidgetsearchline.cpp b721c58 > tests/kcategorizedviewtest.cpp 16dac9a > tests/ktreewidgetsearchlinetest.cpp adaf246 > tests/kwidgetitemdelegatetest.cpp d4bba7a > > Diff: https://git.reviewboard.kde.org/r/126737/diff/ > > > Testing > ------- > > Build without errors. > Tests passed. > > > Thanks, > > Andrey Cygankov > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
