-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126618/
-----------------------------------------------------------
(Updated Jan. 15, 2016, 10:04 p.m.)
Review request for KDE Frameworks.
Changes
-------
Use QCoreApplication::applicationDirPath() in stead and modify the error
message.
I'm not sure my CMake Fu is up to the task of adding
${KDE_INSTALL_FULL_KSERVICETYPES5DIR} + path option...
Repository: kcoreaddons
Description
-------
Without this patch kcoreaddons_desktop_to_json() will not find the destop file.
On windows GenericDataLocation returns "C:/Users/<USER>/AppData/Local" or
"C:/ProgramData". That is not a path that contains any destip files ;)
This patch adds AppLocalDataLocation to the seach if the previous search does
not return a match.
Another option would be to hardcode the absolute path to all places that uses
kcoreaddons_desktop_to_json(), but that does not feel too nice...
What other options do we have?
Diffs (updated)
-----
src/lib/plugin/desktopfileparser.cpp 1122af8
Diff: https://git.reviewboard.kde.org/r/126618/diff/
Testing
-------
KTextEditor compiles again on windows
Thanks,
Kåre Särs
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
