> On Jan. 16, 2016, 1:46 p.m., Alex Merry wrote: > > I think the diff uploaded wrong, because reviewboard thinks all the new > > files are empty. > > > > Also, could you please add test cases to the autotests directory? It > > shouldn't be too complicated, just an example file or two and the PNG > > equivalents.
Okay, will do -- I need my other laptop for that, so it needs to wait until I'm home, though. - Boudewijn ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126675/#review91179 ----------------------------------------------------------- On Jan. 16, 2016, 9:55 a.m., Boudewijn Rempt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126675/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2016, 9:55 a.m.) > > > Review request for KDE Frameworks and Alex Merry. > > > Repository: kimageformats > > > Description > ------- > > These qimageio plugins originally come from krita, but people who haven't got > krita installed might want to view Krita or OpenRaster images as well. Both > formats are really simple, just zip files with a png inside that represents > the merged image. This patch does add a KF5::Archive dependency to > kimageformats. > > > Diffs > ----- > > CMakeLists.txt 1e7e703 > src/imageformats/CMakeLists.txt 8cf8d54 > src/imageformats/kra.cpp PRE-CREATION > src/imageformats/kra.desktop PRE-CREATION > src/imageformats/kra.h PRE-CREATION > src/imageformats/kra.json PRE-CREATION > src/imageformats/ora.cpp PRE-CREATION > src/imageformats/ora.desktop PRE-CREATION > src/imageformats/ora.h PRE-CREATION > src/imageformats/ora.json PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/126675/diff/ > > > Testing > ------- > > > Thanks, > > Boudewijn Rempt > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
