> On Jan. 18, 2016, 4:52 p.m., Aleix Pol Gonzalez wrote: > > src/core/engine.cpp, line 135 > > <https://git.reviewboard.kde.org/r/126798/diff/1/?file=434224#file434224line135> > > > > Shouldn't this break? Otherwise some of the installations won't get > > connected.
No. I think previous code treat as "fatal error" when can't load installation (return false). I didn't change this behaviour. If some category don't have installation method by particular installation or default installation this return false. If category particular installation method load fail this return false because if category has a group I can't fallback to default installation. Sorry my poor English. - Demitrius ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126798/#review91273 ----------------------------------------------------------- On Jan. 18, 2016, 4:27 p.m., Demitrius Belai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126798/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2016, 4:27 p.m.) > > > Review request for KDE Frameworks and Jeremy Whiting. > > > Repository: knewstuff > > > Description > ------- > > This allow to configure installation method per categorie. For example, kwin > aurorae.knsrc > > ``` > [KNewStuff3] > ProvidersUrl=http://download.kde.org/ocs/providers.xml > Categories=Window Decoration Aurorae,KWin Decoration QtQuick > Uncompress=archive > TargetDir=aurorae/themes > > [KWin Decoration QtQuick] > StandardResource=tmp > InstallationCommand=plasmapkg2 -t kwindecoration -i %f > UninstallCommand=plasmapkg2 -t kwindecoration -r %f > ``` > > This don't break backward. Category which don't have group in config will be > installed by default installation method in [KNewStuff3] group. > > > Diffs > ----- > > src/attica/atticaprovider.cpp 07508b05f324f25481bf05c5717c0ca60dce70d1 > src/core/engine.cpp c8d0579eed8592c0c210ad61cbd5cbf4add53f95 > src/core/engine_p.h 11571bfcd030ed2832ae64781323494365837296 > src/core/entryinternal.cpp b05fe24417554b78fc206d3437e4d11ef2eefcb7 > > Diff: https://git.reviewboard.kde.org/r/126798/diff/ > > > Testing > ------- > > > Thanks, > > Demitrius Belai > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
