----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123939/#review92827 -----------------------------------------------------------
This commit added a Help button which .... does nothing. If the apps don't connect to it, the users end up with a broken Help button. I don't think it was a good idea .... but I also don't think we can fix it anymore, otherwise apps that relied on this and just called button(Help) would get a null ptr now and crash. So, too late, but for the record, I think this was a bad idea ;-) See also https://phabricator.kde.org/D1025 - David Faure On June 2, 2015, 9:30 p.m., Alexander Potashev wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123939/ > ----------------------------------------------------------- > > (Updated June 2, 2015, 9:30 p.m.) > > > Review request for KDE Frameworks, Christoph Feck and Kevin Ottens. > > > Repository: kwidgetsaddons > > > Description > ------- > > The Help button was removed from KAssistantDialog while moving from > kdelibs4 to KF5. > > > Diffs > ----- > > src/kassistantdialog.cpp f9978a7bcb7287f0f4c8d48fd7fbb9edde80d45c > > Diff: https://git.reviewboard.kde.org/r/123939/diff/ > > > Testing > ------- > > The wizard dialog in KIPI plugin "Export to Flash" now has the same buttons > as in its KDELibs4-based versions. Before this patch, the dialog did not have > the Help button which I guess is important for KIPI plugins. > > > Thanks, > > Alexander Potashev > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
