----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127209/#review92912 -----------------------------------------------------------
src/lib/io/kprocess_p.h (line 33) <https://git.reviewboard.kde.org/r/127209/#comment63371> Why not have a constructor that takes the q ptr? The only code that uses it does: d_ptr(new KProcessPrivate) d_ptr->q_ptr = this; - Kai Uwe Broulik On Feb. 29, 2016, 1:29 nachm., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127209/ > ----------------------------------------------------------- > > (Updated Feb. 29, 2016, 1:29 nachm.) > > > Review request for KDE Frameworks. > > > Repository: kcoreaddons > > > Description > ------- > > Mostly initializing values and using printf() correctly. > > > Diffs > ----- > > src/lib/io/kdirwatch.cpp f2fd3b8 > src/lib/io/kprocess_p.h 70fe91f > src/lib/kaboutdata.cpp a220977 > src/lib/randomness/krandom.cpp bdbdec6 > src/lib/util/kformatprivate.cpp 3d98007 > > Diff: https://git.reviewboard.kde.org/r/127209/diff/ > > > Testing > ------- > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
